Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn of detected absolute URLs while scanning build output via UrlCrawl #59

Open
Blazzike opened this issue Mar 7, 2023 · 0 comments
Open

Comments

@Blazzike
Copy link
Collaborator

Blazzike commented Mar 7, 2023

PR #58 will introduce a UrlCrawl class/functionality that finds broken URLs. As a later feature, this class should also be able to find absolute URLs and print those as part of the final output.

Currently the output of failing HREFs prints as the following (note the first path is not actually the value of the href, absolute URLs are always displayed):

404 Not Found a[href="/tutorials/webgl/webgl_fundamentals/"] @ /webgl-transforms/

The detected absolute URLs could display along the lines of:

[!] Absolute a[href="/tutorials/webgl/webgl_fundamentals/"] @ /webgl-transforms/

Finally, this functionality ideally would be toggleable using a UrlCrawl option such as shouldWarnAbsolute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant