Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

chore: code clean up from webdev infra aside implementation #9929

Conversation

ShayPunter
Copy link
Contributor

@ShayPunter ShayPunter commented Apr 20, 2023

Fixes GoogleChrome/webdev-infra#77

Changes proposed in this pull request:

  • Migrate aside component to webdev-infra
  • A clean up of the now unused aside files in web.dev
  • Updated handbook component to include new tip aside

@google-cla
Copy link

google-cla bot commented Apr 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for web-dev-staging failed.

Name Link
🔨 Latest commit fa4579b
🔍 Latest deploy log https://app.netlify.com/sites/web-dev-staging/deploys/64410f476e697600088583f9

Copy link

@jimjiminyjimjim jimjiminyjimjim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShayPunter ShayPunter marked this pull request as ready for review April 24, 2023 09:34
@stale
Copy link

stale bot commented Aug 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To prevent this from happening, leave a comment.

@stale stale bot added the stale label Aug 12, 2023
@devnook devnook closed this Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate and consolidate aside implementations in webdev-infra, implement Tip type
3 participants