Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm sample #841

Merged
merged 17 commits into from
May 12, 2023
Merged

Add wasm sample #841

merged 17 commits into from
May 12, 2023

Conversation

daidr
Copy link
Contributor

@daidr daidr commented Mar 3, 2023

Adds a sample for using wasm in Manifest V3, I kept the wasm-pack build artifacts but I'm not sure if that's right.

fixes #775

Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments and some suggested changes, but overall this looks great! I think keeping the generated artifacts is the right thing since it keeps this simple for people to try. Thanks for working on it!

@oliverdunk oliverdunk self-assigned this May 10, 2023
@daidr daidr requested a review from oliverdunk May 11, 2023 18:18
Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this, super excited to have the new samples! LGTM 🚀

@oliverdunk oliverdunk merged commit eb6badb into GoogleChrome:main May 12, 2023
@patrickkettner
Copy link
Collaborator

thanks so much, @daidr! really stoked to see this land!

@daidr daidr deleted the wasm-sample branch May 12, 2023 10:47
2qg4svr pushed a commit to 2qg4svr/chrome-extensions-samples that referenced this pull request Jun 3, 2023
* Add wasm sample

* Add README

* Fix indent in README

* Add a sample that doesn't use module to import wasm

* fix: added new line at the end of files

* Removed sample with format marco & extra space

* No more extern crate

* Sync changes

* Added new line at the end of files

* Update output

* Update footnotes

* Removed reference for unpacked extension

* Used new README template

* Update dependencies

* Update build artifacts

* fix: typo

* Update files with latest version of rustc

---------

Co-authored-by: Oliver Dunk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample: Using WASM in Manifest V3
3 participants