-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wasm sample #841
Add wasm sample #841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments and some suggested changes, but overall this looks great! I think keeping the generated artifacts is the right thing since it keeps this simple for people to try. Thanks for working on it!
functional-samples/cookbook.wasm-helloworld-print-nomodule/README.md
Outdated
Show resolved
Hide resolved
functional-samples/cookbook.wasm-helloworld-print-nomodule/README.md
Outdated
Show resolved
Hide resolved
functional-samples/cookbook.wasm-helloworld-print-nomodule/manifest.json
Outdated
Show resolved
Hide resolved
functional-samples/cookbook.wasm-helloworld-print-nomodule/wasm/src/lib.rs
Outdated
Show resolved
Hide resolved
functional-samples/cookbook.wasm-helloworld-print-nomodule/wasm/src/lib.rs
Outdated
Show resolved
Hide resolved
functional-samples/cookbook.wasm-helloworld-print-nomodule/wasm/src/lib.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work on this, super excited to have the new samples! LGTM 🚀
thanks so much, @daidr! really stoked to see this land! |
* Add wasm sample * Add README * Fix indent in README * Add a sample that doesn't use module to import wasm * fix: added new line at the end of files * Removed sample with format marco & extra space * No more extern crate * Sync changes * Added new line at the end of files * Update output * Update footnotes * Removed reference for unpacked extension * Used new README template * Update dependencies * Update build artifacts * fix: typo * Update files with latest version of rustc --------- Co-authored-by: Oliver Dunk <[email protected]>
Adds a sample for using wasm in Manifest V3, I kept the wasm-pack build artifacts but I'm not sure if that's right.
fixes #775