Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GoodID-dapp] GoodID-Details #547

Open
1 of 3 tasks
decentralauren opened this issue Apr 1, 2024 · 5 comments
Open
1 of 3 tasks

[GoodID-dapp] GoodID-Details #547

decentralauren opened this issue Apr 1, 2024 · 5 comments
Assignees

Comments

@decentralauren
Copy link
Contributor

decentralauren commented Apr 1, 2024

Business Description

Prior to going through the upgrade flow, users who have connected their wallets and are already whitelisted will see the option to Upgrade their GoodID from the GoodID page in the Dapp.

This ticket includes updating the GoodID page to include FAQs and the new page layout.

Detailed Description of Functionality

A detailed description is here GoodIdDetails component

Technical Implementation

Design reference:

See this ticket for reference.

  • FIgma - non-Upgrade device

Acceptance Criteria

  • If the user has their wallet connected,
  • and their wallet has previously been Face Verified
  • and their wallet has not been through the latest FV / GoodID Upgrade
  • then the Upgrade button should appear and drive them into the GoodID Upgrade flow
@L03TJ3 L03TJ3 transferred this issue from GoodDollar/GoodDAPP Apr 4, 2024
@L03TJ3
Copy link
Collaborator

L03TJ3 commented Apr 9, 2024

@sirpy @johnsmith-gooddollar
How would we determine if someone has done the upgrade flow?
Some options are obvious:
a. user has an existing Identity certificate in storage: has done the upgrade flow

b. a user has no existing certificates but his last face-verification was done after the launchdate of goodid: has done upgrade flow

c. a user has no existing certificates and is part of the group with an expiry date longer than three months so it did not have to do the face-verification. How can we know if someone already did the upgrade flow?

I would not know how we would handle case C

@sirpy
Copy link
Contributor

sirpy commented Apr 11, 2024

@L03TJ3 i dont see this screen in the onboarding flow #550 you blocked by this issue. Why did you block it then?

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Apr 12, 2024

@sirpy because the onboard-flow is done on the good-id page, which would have various states (see #550 description)
above view is one of the states

@L03TJ3 L03TJ3 changed the title [GoodID] Update Dapp GoodID page pre-upgrade [GoodID] Update Dapp GoodID page for pre/post upgrade state Apr 12, 2024
@decentralauren
Copy link
Contributor Author

decentralauren commented Apr 15, 2024

  • Add third state for other device (non-upgrade device): When the user is viewing their GoodID on a device OTHER than the device they used to upgrade, they will only see 1) wallet address 2) expiry date and 3) text that says "You used a different device to upgrade your GoodID. Please check that device for more GoodID details"
  • update to remove "upgrade" button
  • Need an "are you sure" modal when user clicks trashcan (on FaceID widget) and to design the "delete FaceID" flow so it's clear to user that 1) they need to wait 24 hours before re-verifying and 2) they cannot use GoodDollar (incl claim) until you have re-verified.

@decentralauren @SanaJamm

Update in this ticket (for component build)

@decentralauren decentralauren self-assigned this Apr 15, 2024
@decentralauren decentralauren changed the title [GoodID] Update Dapp GoodID page for pre/post upgrade state [GoodID-dapp] GoodID-Details Apr 16, 2024
@L03TJ3
Copy link
Collaborator

L03TJ3 commented Sep 15, 2024

@decentralauren part of this: https://app.zenhub.com/workspaces/goodlabs-61559a6a33275e00141f8ee4/issues/gh/gooddollar/goodweb3-mono/194

So this can be closed, or needs to be updated ( this is for the dapp implementation specifically, so I guess the latter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants