Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a way to go from changes and a revision to the revision issuer #28

Open
Gnuxie opened this issue Apr 15, 2024 · 0 comments

Comments

@Gnuxie
Copy link
Owner

Gnuxie commented Apr 15, 2024

async function groupRulesByIssuer(policyRoomManager: PolicyRoomManager, changesByList: ChangesByRoomID): Promise<ActionResult<GroupedChanges[]>> {
    for (const [roomID, changes] of changesByList) {
        const issuer = await policyRoomManager.getPolicyRoomRevisionIssuer(MatrixRoomReference.fromRoomID(roomID));
    }
}

This kind of code shouldn't be happening... We can't avoid aggregating changes into other revisions, so maybe this needs to happen at the rule level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant