From 83b49c34fee75a5c4363a3d463800e58bf9cac19 Mon Sep 17 00:00:00 2001 From: Geert Janssens Date: Tue, 31 Dec 2024 15:30:43 +0100 Subject: [PATCH] Allow more account types in the payment window's transfer account list So far it was limited to Asset, Liability, Credit Card and either Income (for customer payments) or Expenses (for vendor payments). There are however use cases where a customer payment also covers expenses (like for example a Paypal service charge). To allow for as many edge cases as possible the filter now only excludes those account types I worry will break the business logic: AP and AR accounts. That is, with this change you won't be able to create a customer payment (which necessarily has one split an an AR account) that transfers to another AR or to an AP account. While even that may work, I am sure the business features weren't designed to cope with this and I can't exhaustively test that. --- gnucash/gnome/dialog-payment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnucash/gnome/dialog-payment.c b/gnucash/gnome/dialog-payment.c index d73d0933614..10c4aa0bb13 100644 --- a/gnucash/gnome/dialog-payment.c +++ b/gnucash/gnome/dialog-payment.c @@ -1150,7 +1150,7 @@ gnc_payment_set_account_types (GncTreeViewAccount *tree) gnc_tree_view_account_get_view_info (tree, &avi); for (i = 0; i < NUM_ACCOUNT_TYPES; i++) - avi.include_type[i] = gncBusinessIsPaymentAcctType (i); + avi.include_type[i] = !xaccAccountIsAPARType (i); gnc_tree_view_account_set_view_info (tree, &avi); }