Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NACKs to more gracefully handle RTP sequence # rollover #95

Closed
haydenmc opened this issue Mar 6, 2021 · 2 comments · Fixed by #127, #121 or #122
Closed

Fix NACKs to more gracefully handle RTP sequence # rollover #95

haydenmc opened this issue Mar 6, 2021 · 2 comments · Fixed by #127, #121 or #122

Comments

@haydenmc
Copy link
Member

haydenmc commented Mar 6, 2021

No description provided.

haydenmc added a commit that referenced this issue Mar 6, 2021
@haydenmc
Disable NACKs until #95 can be addressed
e010faa
@haydenmc haydenmc mentioned this issue Mar 6, 2021
Merged
haydenmc added a commit that referenced this issue Mar 6, 2021
@haydenmc
🛑 Disable NACKs until bug can be addressed (#96)
f414a7a 
We're seeing issues where on RTP sequence number rollover, we mark an enormous packet range as "lost".

To expedite production stability, we're disabling this feature entirely until the issue can be resolved. #95
@danstiner danstiner mentioned this issue Apr 16, 2021
Open
@danstiner
Copy link
Collaborator

danstiner commented Apr 17, 2021 •
edited
Loading

My rough plan is to:

This was referenced Apr 20, 2021
Merged
Open
This was linked to pull requests Apr 22, 2021
♻️ Extract sendNack method #121
Merged
🧮 Extended sequence number counter #122
Merged
@danstiner
Copy link
Collaborator

Will follow up with tests later as part of improving metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@danstiner @haydenmc