Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuthKaab fails without an error message when no data are available #343

Closed
erikmannerfelt opened this issue Mar 20, 2023 · 2 comments
Closed

NuthKaab fails without an error message when no data are available #343

erikmannerfelt opened this issue Mar 20, 2023 · 2 comments
Labels
invalid This doesn't seem right priority Needs to be fixed rapidly

Comments

@erikmannerfelt
Copy link
Contributor

When a TBA raster is empty (or at least when elevation_difference / slope is only nan), NuthKaab fails with an empty AssertionError. It would be quite easy to fix this, as the error message should just be something along "input raster values do not overlap", or "at least one of the rasters are empty".

xdem/xdem/coreg.py

Line 95 in f40e897

assert y_values.shape[0] > 0

@erikmannerfelt erikmannerfelt added the invalid This doesn't seem right label Mar 20, 2023
@rhugonnet rhugonnet added the priority Needs to be fixed rapidly label Aug 1, 2023
@rhugonnet
Copy link
Member

Fixed by #530, but leaving this open so that we add a test to check the error raised

@rhugonnet
Copy link
Member

This is closed by

xdem/tests/test_coreg/test_base.py

Line 541 in 22dbe7c

("dem1 + np.nan", "dem2", "None", "None", "fit", "error", "'reference_dem' had only NaNs"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right priority Needs to be fixed rapidly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhugonnet @erikmannerfelt