-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with database version 118 #51
Comments
By reading database (with DB Browser for SQLite) I see the structure of the table "thread" : I can't see |
Hi @Martin-bcd, What version of signal2html are you using? From your error message above it looks like you may be using an older version. Try updating it with |
Thanks, it seems to work 😄 |
OK, As soon as I closed the issue, it failed again ! 😓
Always the same warning on top : |
Thanks for testing this @Martin-bcd! 👍 Glad to hear we got one issue fixed at least! It sounds like the issue you have now is the same as in #52. If you like, you can try the fix that I've suggested there to see if that solves it (that would help me to figure out the issue). The warning about the untested Signal database version means that you're on a version that I've not tried yet, so I can't guarantee that it works (which, in this case, it doesn't). As soon as we figure out how to fix this and we get it to work, I'll update the code and remove that warning :) |
OK. Thank.
Thank you :-) |
the first run I got a folder with : 4 624 elements, 7,3 Go |
Thanks for the additional testing @Martin-bcd! This helps to figure out what's going on. @ericthegrey do you have any thoughts on this? It looks like the StructuredGroupDataV2 protobuf message has changed but I'm not sure where in the Signal source this is defined. The other issue is that None data isn't handled properly, but that's more a workaround I think. Thanks! |
Hi, I can't look at this in details for some time, but it looks like the top level structure of this message is different (it might encapsulate the previous one). Perhaps the data type field has been updated to indicate this, or perhaps the change is implicit in the new database version (I haven't found a content upgrade procedure, however, but I looked only briefly). @GjjvdBurg FYI - you can find the original proto for the previous structure here: https://github.com/signalapp/Signal-Android/blob/master/libsignal/service/src/main/proto/DecryptedGroups.proto#L69 and the one I suspect is now used at: https://github.com/signalapp/Signal-Android/blob/master/app/src/main/proto/Database.proto#L47 |
@GjjvdBurg - I would suggest writing some warning when outputting message data in logs, since people might not realize this could contain confidential message information when pasting it in bug reports (perhaps there could be a more confidential way to share as it turns out to be quite useful to find problems -- https://www.npmjs.com/package/cipherhub maybe). |
Thanks @ericthegrey! That pointer helped me figure out that changing the fields to optional makes it possible to parse the change update. Also, a good point regarding the logging output, I've removed that for now and will look into other ways of sharing debug logs. @Martin-bcd, would you mind testing the updated branch to see if this fixes the issue? You can use the same commands as in your message above. Thanks! |
Hello and thank you for your job 🙂
I already ran signal2html with success but this time it's not working 😕
I've got this :
Unfortunately I can't help more, I don't understand anythings about Python 😓 🐍
But I am ok to contribute with beers 🍻 (or something else)
Thanks for your help 🙂
The text was updated successfully, but these errors were encountered: