Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Adopt scalar type hints and return types #680

Open
pfrenssen opened this issue Jul 31, 2020 · 0 comments
Open

Adopt scalar type hints and return types #680

pfrenssen opened this issue Jul 31, 2020 · 0 comments

Comments

@pfrenssen
Copy link
Contributor

pfrenssen commented Jul 31, 2020

Now that we no longer support PHP 5 we can adopt scalar type hints and return types for our interfaces and protected methods.

Since changing interface signatures is a B/C break we should do this before we release a beta version.

I don't think it is necessary to perform this task in a single PR because of our large number of interfaces. It's OK to spread this over a number of PRs that cover a few interfaces/classes each. That would make it easy to review + merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant