From 82cbc0af401b75fcc5c2d91bfe7dcd9cb9cd8570 Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Thu, 28 Nov 2024 02:54:47 -0500 Subject: [PATCH] Simplify the `check-mode` CI job By running it only on Ubuntu (not macOS and Windows), and removing parts that were only needed for running it on Windows. Unlike `etc/copy-packetline.sh`, the `etc/check-mode.sh` script probably does not need to be made easy to retest on other platforms after changes, becaus it does not delete (nor otherwise modify) the repository, and becuase it is considerably shorter, simpler, and less reliant on subtleties of standard tools that vary across platforms. --- .github/workflows/ci.yml | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7c4261d842c..42246e7e52f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -360,17 +360,7 @@ jobs: run: cd gix-pack && cargo build --all-features --target "$TARGET" check-mode: - # FIXME: Only run this on ubuntu-latest (don't use a matrix). - strategy: - fail-fast: false - matrix: - os: [ ubuntu-latest, macos-latest, windows-latest ] - - runs-on: ${{ matrix.os }} - - defaults: - run: - shell: bash + runs-on: ubuntu-latest steps: - uses: actions/checkout@v4