From 0384a4cd0d111970895840de8c6cf60a1cdd968c Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Wed, 27 Nov 2024 21:05:27 -0500 Subject: [PATCH 1/2] Revert "Set nextest behavior on empty runs more explicitly" This reverts commit 2fc93f76798ce35f038d52a85b1841fff5280837. The change to the `justfile` should be kept, but is temporarily reverted to verify that the change in `ci.yml` is no longer needed. --- .github/workflows/ci.yml | 1 - justfile | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index aa5ec02f2d9..afc1cea684a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,6 @@ permissions: env: CARGO_TERM_COLOR: always CLICOLOR: '1' - NEXTEST_NO_TESTS: fail jobs: pure-rust-build: diff --git a/justfile b/justfile index 6323a0670da..c82db16edf8 100755 --- a/justfile +++ b/justfile @@ -186,7 +186,7 @@ unit-tests: cargo nextest run -p gix --no-default-features --features basic,extras,comfort,need-more-recent-msrv cargo nextest run -p gix --features async-network-client cargo nextest run -p gix --features blocking-network-client - cargo nextest run -p gitoxide-core --lib --no-tests=warn + cargo nextest run -p gitoxide-core --lib # These tests aren't run by default as they are flaky (even locally) unit-tests-flaky: From 5f1fa6c297cf1136ad90b15d9c7a20cd302f64b0 Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Wed, 27 Nov 2024 21:06:46 -0500 Subject: [PATCH 2/2] Bring back `--no-tests=warn` when needed `justfile` This was temporarily removed to verify that we no longer need to set `NEXTEST_NO_TESTS` to `fail` explicitly in `ci.yml` to get that failing behavior, now that it is implied starting in `cargo-nextest` version 0.9.85. It is now brought back, so that we do not get that error in the one place where we know there are no test cases yet do tell `nextest` to run tests. --- justfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/justfile b/justfile index c82db16edf8..6323a0670da 100755 --- a/justfile +++ b/justfile @@ -186,7 +186,7 @@ unit-tests: cargo nextest run -p gix --no-default-features --features basic,extras,comfort,need-more-recent-msrv cargo nextest run -p gix --features async-network-client cargo nextest run -p gix --features blocking-network-client - cargo nextest run -p gitoxide-core --lib + cargo nextest run -p gitoxide-core --lib --no-tests=warn # These tests aren't run by default as they are flaky (even locally) unit-tests-flaky: