Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Text styling support #3

Open
kriskenyon opened this issue Mar 10, 2020 · 3 comments
Open

Improved Text styling support #3

kriskenyon opened this issue Mar 10, 2020 · 3 comments
Labels
under review Under review for inclusion on the roadmap

Comments

@kriskenyon
Copy link

It would be helpful to have increased control over Text like being able to change the color within the text string of a specific word, changing fonts on selection and general formatting controls in a more consistent control over the formatting of text. (Leaving this open ended for others to chime in)

@anthonyjb anthonyjb added the under review Under review for inclusion on the roadmap label Mar 10, 2020
@anthonyjb
Copy link
Member

@kriskenyon thanks for the input 👍 I've previously written a tools for doing font family variation as a plug-in for a client, I shared my approach and code here: https://anthonyblackshaw.me/2018-01-22/font-family-selector

How do you see font family, size and color being applied, my issue with this has always been a dislike for applying inline styles. However, I would be interested in vastly improving the styles selection area in the properties tool so that you could:

  • Access it more easily and without a modal covering your content
  • Providing a preview of the styles applicable to the content you have selected

Would that be a suitable approach for the way you work? It would mean defining in advance what styles a user could apply, is that flexible enough?

@kriskenyon
Copy link
Author

@anthonyjb I have a client that LOVES color and wants to draw attention to particular words by changing color font etc. I moved from ckeditor to ContentTools and it is better in almost every way but I still hear about that one feature. I did implement block level items via CSS and other tricks but that does not get to the word level.
As to the inline markup I had to manually edit everything from ckeditor to remove that and I fully understand the hesitation. I wonder if something could be done with string positions to achieve this but my fear is that the performance would utterly tank and the complexity would get overwhelming quickly.
Even though this feels like "not a feature ContentTools will implement" if you come up with a ah ha moment let me know. Perhaps I can implement a plugin.

@anthonyjb
Copy link
Member

@kriskenyon we all have those clients 😆

So actually I've written a number of extensions for people which allow you to mark inline sections of text, usually by just extending the bold tool and changing what it applies (to do things like highlight sections of text in a paragraph). Performance wise I don't think you'll have an issue as CT only makes one paragraph block editable at a time. However, building the interface to allow selection of font family, size, style and colour given the very bare bones UI tools available at the moment is another matter.

A new underlying UI will be a freature of ContentTools 2 to make it much easier to extend the UI for your own purposes and to unify the UI across CE, CT and CF (all currently use different approaches). So this should make the creation of such an extension relatively easy.

I'm going to leave this issue open for discussion for now if that's OK, you're not the first person over the years to want this feature for a client and I'm interested to see how others have solved it and if their is better advice on the matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under review Under review for inclusion on the roadmap
Projects
None yet
Development

No branches or pull requests

2 participants