motor compability

[njordr]

Hi.

Is it compatible also with motor https://motor.readthedocs.io/en/stable/ (so it can work with async)?

[anthonyjb]

Hi @njordr,

No the under the hood we're using PyMongo and whilst I imagine it would very feasible to add Motor support (perhaps a MotorFrame class) that's not there at the moment.

I've used Motor quite a bit (with Tornado) so would feel reasonably comfortable attempting this, I'll flag this as an enhancement and look to implement in a near future release.

I'm currently writing a large chunk of documentation for the new data factory functionality so this will be a nice distraction from that :)

[njordr]

That would be great, thanks

[anthonyjb]

@njordr looks like it may not be possible right now unless I limit the version of PyMongo available to users of MongoFrames to only PyMongo 2.8 (Motor requires that version exactly of PyMongo). Currently the default for MongoFrames is PyMongo 3+

I wouldn't be very keen on this restriction, perhaps I've miss-understood the limitation, would gladly take advice from some else more knowledgeable on Motor (maybe @ajdavis) - I'm reading from https://motor.readthedocs.io/en/stable/requirements.html.

I suppose one option would be to provide a separate version of the library, e.g MotorFrames that was kept inline with MongoFrames - though I was hoping to be able to keep a single code base.

[njordr]

that's not good 👎

it's a very bad idea to have two different libraries. I hope in the meantime the motor library will be upgraded to the last of pymongo..

[ajdavis]

Upgrading Motor's PyMongo dependency has reached the front of my queue now:

https://jira.mongodb.org/browse/MOTOR-87

It'll be done by end of quarter. @anthonyjb it might be hard for you to begin development of MongoFrames + Motor right now, until I get Motor basically working with PyMongo 3. You can sign up for Jira and watch that ticket for email updates on my progress.

[anthonyjb]

Thanks @ajdavis - great news and thanks for the swift response. I've signed up to Jira and will track the ticket.

[njordr]

Thank you both, really :)

[anthonyjb]

@njordr motor 1.0 was just released which brings the PyMongo dependancy to 3+ and so this change should now be possible and I'll be looking at it over the coming weeks.

[njordr]

Great, thanks

[ajdavis]

Let me know if you have questions or discover issues, please.