-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Selection Dropdown UX Enhancements #1 #53
Comments
Hi @anjj123 , except no.8, the rest of the items have been improved or fixed. Please verify. Thanks. |
Most of these are completed. There are still some issues:
OP has been edited to reflect these issues |
3 does it happens when adding/importing an account or when switching between accounts? 4 this could be a future enhancement |
New issue:
Updating OP to reflect these issues. For now, if we can solve the UX issue of switching between accounts sometimes requiring multiple clicks, the rest can be dropped to low priority. |
I cannot seem to reproduce the issue that switching accounts requires multiple clicks. @anjj123 please try to reproduce it and see if there is any pattern so that we can reproduce it and debug. Other than that, everything should be fixed now. |
You can see it on the gif i provided in the balance bug that we recently completed. The pattern seems to be that once I import an account with a balance, there is a performance issue with switching accounts |
@fyang1024 I have reproduced the issue again here |
List of Account Selection Dropdown UX Enhancements:
1. Line separating accounts, and creation + import should not be selectable;The highlighting effect when cursor moves over options isn't noticeable enough;It just needs to be added for create/import3. Dropdown highlight selection always defaults to the first account in the list, even if another account is selected;This was removed altogether.4. The highlighted box doesn't cover the whole field (wallet name and public address - maybe move these closer or make the box larger)Dropdown box should be bigger, centered and closer to designs + text should also be a bit bigger (hard to read);6. Selected account should be highlighted in the dropdown or go to the top of the list, and not always highlight the first account - also, the highlight isnt that noticeable;RemovedSometimes clicking to change accounts doesnt work - extension wont respond and requires a few clicks (firefox and chrome);
Ability to move and reorganise accounts in the list; and
9. Grey box on account name when clicking dropdownThe text was updated successfully, but these errors were encountered: