Build with GHC 9.8 #249
Merged
Build with GHC 9.8 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves GetShopTV#248
This reverts commit 9f91db6.
To ease debugging, do not fail all jobs immediately when one of them fails.
|
@swamp-agr Looks good to me, pinging you in case you haven't gotten a notification for this. |
|
@wolfgangwalther thank you for the patch! My thought process was including CPP extension for some reason. I really like the solution you found! 👍 @ysangkok thanks for pinging me! |
swamp-agr
approved these changes
Jan 26, 2024
|
I am going to prepare release during the weekend. Stay tuned. |
|
Please find release on Hackage: https://hackage.haskell.org/package/swagger2-2.8.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit solves #248. A bit hacky, but maybe somebody else comes up with a better idea?
The second commit builds with GHC 9.8.
The third commit removes
allow-newersfor GHC 9.6 - it seems to build without them fine by now.The last commit just allow all CI jobs to keep running while one of them fails - helpful to find out that maybe more than one build is failing.