Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate external id #77

Closed

Conversation

keremdokuz
Copy link
Collaborator

ensures that external_id of a view is always unique globally, see slackapi/node-slack-sdk#1012 (comment)

also ensures time between rotations is always positive

Copy link
Owner

@Germandrummer92 Germandrummer92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, did you try to run it locally https://github.com/Germandrummer92/SchedSlackBot/blob/main/sched_slack_bot/model/schedule.py#L149 ? I will also invite you to my playground slack workspace so you don't need to setup one yourself

sched_slack_bot/views/schedule_dialog.py Outdated Show resolved Hide resolved
sched_slack_bot/utils/fix_schedule_from_the_past.py Outdated Show resolved Hide resolved
@keremdokuz
Copy link
Collaborator Author

Thanks for the contribution, did you try to run it locally https://github.com/Germandrummer92/SchedSlackBot/blob/main/sched_slack_bot/model/schedule.py#L149 ? I will also invite you to my playground slack workspace so you don't need to setup one yourself

sadly I wasn't able to run it locally, where can I find the invite?

sched_slack_bot/utils/fix_schedule_from_the_past.py Outdated Show resolved Hide resolved
sched_slack_bot/model/schedule.py Outdated Show resolved Hide resolved
kosta
kosta previously approved these changes Sep 6, 2023
Copy link
Collaborator

@kosta kosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from my side but testing this in another workspace would be nice

@Germandrummer92
Copy link
Owner

Thanks for the contribution, did you try to run it locally https://github.com/Germandrummer92/SchedSlackBot/blob/main/sched_slack_bot/model/schedule.py#L149 ? I will also invite you to my playground slack workspace so you don't need to setup one yourself

sadly I wasn't able to run it locally, where can I find the invite?

I sent it to the email that was listed on linkedin, hotmail I believe :)

Germandrummer92
Germandrummer92 previously approved these changes Sep 6, 2023
sched_slack_bot/views/schedule_dialog_block_ids.py Outdated Show resolved Hide resolved
sched_slack_bot/views/schedule_dialog_block_ids.py Outdated Show resolved Hide resolved
test_sched_slack_bot/views/test_schedule_dialog.py Outdated Show resolved Hide resolved
test_sched_slack_bot/views/test_schedule_dialog.py Outdated Show resolved Hide resolved
@Germandrummer92 Germandrummer92 force-pushed the fix-duplicate-external-id branch from 75fac75 to 1e65b58 Compare September 6, 2023 11:16
@Germandrummer92
Copy link
Owner

merged in #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants