-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: duplicate external id #77
fix: duplicate external id #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, did you try to run it locally https://github.com/Germandrummer92/SchedSlackBot/blob/main/sched_slack_bot/model/schedule.py#L149 ? I will also invite you to my playground slack workspace so you don't need to setup one yourself
sadly I wasn't able to run it locally, where can I find the invite? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine from my side but testing this in another workspace would be nice
I sent it to the email that was listed on linkedin, hotmail I believe :) |
75fac75
to
1e65b58
Compare
merged in #79 |
ensures that external_id of a view is always unique globally, see slackapi/node-slack-sdk#1012 (comment)
also ensures time between rotations is always positive