Prevent integer overflow for large grid files in gwb-grid #702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When visualizing a large grid file with gwb-grid I noticed a broken .vtu output even though the .wb file worked for smaller resolutions. Turns out there is a conversion to
int
in the output even though the vector type for the output isvtu11::VtkIndexType
which resolves tostd::int64_t
. This PR fixes the problem and I can visualize the .vtu file correctly. Btw: This is not just a problem for outputs with >2 billion points, as the indices and connectivity for the output can reach this threshold much sooner, the model in question for me had 300 million points.