Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake issues when using DebugRelease in ASPECT. #699

Conversation

MFraters
Copy link
Member

mirroring the changes in geodynamics/aspect#5584

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.19%. Comparing base (a8702f7) to head (af5119e).
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
- Coverage   98.24%   98.19%   -0.06%     
==========================================
  Files         107      107              
  Lines        7464     7465       +1     
==========================================
- Hits         7333     7330       -3     
- Misses        131      135       +4     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8702f7...af5119e. Read the comment docs.

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.021 ± 0.004 (s=449) 1.022 ± 0.003 (s=435) -0.0% .. +0.1%
Slab interpolation curved simple none 1.026 ± 0.056 (s=431) 1.018 ± 0.005 (s=453) -1.6% .. +0.1%
Spherical slab interpolation simple none 1.179 ± 0.006 (s=375) 1.179 ± 0.006 (s=391) -0.0% .. +0.2%
Slab interpolation simple curved CMS 1.057 ± 0.004 (s=401) 1.061 ± 0.004 (s=451) +0.2% .. +0.4%
Spherical slab interpolation simple CMS 1.559 ± 0.009 (s=271) 1.557 ± 0.009 (s=309) -0.2% .. +0.1%
Spherical fault interpolation simple none 1.176 ± 0.006 (s=376) 1.176 ± 0.012 (s=392) -0.3% .. +0.1%
Cartesian min max surface 2.306 ± 0.018 (s=204) 2.310 ± 0.022 (s=188) -0.1% .. +0.5%
Spherical min max surface 7.105 ± 0.065 (s=68) 7.118 ± 0.061 (s=61) -0.3% .. +0.7%

@tjhei
Copy link
Contributor

tjhei commented Mar 12, 2024

Thank you!

@gassmoeller gassmoeller merged commit 1f5fe62 into GeodynamicWorldBuilder:main Mar 13, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants