Add basic starter tutorial mass conserving and plume chapters #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MFraters
force-pushed
the
add_BST_mass_conserving_and_plume_chapters
branch
from
6606c0f to
fc19da7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
+ Coverage 98.24% 98.28% +0.04%
==========================================
Files 107 107
Lines 7341 7341
==========================================
+ Hits 7212 7215 +3
+ Misses 129 126 -3 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MFraters
force-pushed
the
add_BST_mass_conserving_and_plume_chapters
branch
from
39d617b to
6b34e70
Compare
MFraters
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mass conserving slab temperature and the plume feature are two relatively new additions to the world builder and I think new users should be introduced to them already in the starter tutorial. This should not go in depth, because it should point to the cookbooks for details.
The chapter on the mass conserving is done and ready for review, and I am in the process of finishing up the chapter on the simple plume, so that should be done soon as well.
Here is what the model for BST 17 and 18 more or less will look like: