-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rounded fault #484
base: main
Are you sure you want to change the base?
Rounded fault #484
Conversation
Hey @alarshi, Thanks that you are willing to contribute this work back to the world builder! I can take a closer look at the code when I get back from traveling. Could you rebase in the meantime and squash your commits down a bit? Preferably in logical blocks. Thanks! |
It would be nice if you could rebase to the latest GWB main version as it is quite difficult to configure this current version with the current ASPECT master. |
@tjhei : Yes, I agree that this version is not compatible with the main ASPECT and I have been working around this with the old CMakeLists. However, I was not able to rebase this version on the main WB either because a lot of the core code has changed/restructured on which the commits of this branch were based of. I discussed with @MFraters on leaving this branch here for reference and getting the functionality in WB as separate PRs. I still need to figure out the differences between the main and this branch results for our models. This is one of my goals for this hackathon. |
I am pushing this branch which we we have been using for our global mantle flow models. This PR is only to get the relevant commits from this branch merged into current main.
@gassmoeller : The commits using the rounded corners and interpolation between two very closely spaced faults are : 3e88817
d18d1c4
e33e739