-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP TEST] Astyle 3.1 #421
base: main
Are you sure you want to change the base?
Conversation
Forgot to say that his came up in #420 |
Codecov Report
@@ Coverage Diff @@
## main #421 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 86 86
Lines 5038 5038
=======================================
Hits 5013 5013
Misses 25 25
Continue to review full report at Codecov.
|
|
Yes, this really isn't very much. It would be interesting to see how that looks like for ASPECT. I also think you're right that you should exclude imported projects from indentation. These ought to be preserved in exactly the state they were imported in. |
This pull request is a test to see the differences between astye 2.04 and astyle 3.1. I am currently not thinking of switching before the next release (and maybe not even after), but I was curious to see how different it would be and provide an easy way to view and discuss the differences.
The pull request is divided into two commits. The first commit contains the persistent changes (2.04->3.1->2.04). The second commit contains the non-persistent changes.
There are not many changes (60 lines in total). A large part of the changes in both commits are in the doctest library and the rapidjson library, which maybe should not even be part of the indent (but that is a separate discussion I guess). If you exclude those libraries there are 32 lines which change within the world builder, of which 16 are persistent.