Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #51] Bug: creating user via json_content expects username, also fixes bug when using delete user #62

Conversation

mwallschlaeger
Copy link
Contributor

Description

function expected to always receive a username, but if user gets created via json object username is contained inside json so no additional username must be defined. #51

Further deleting users was using the geonodeobject.py implementation which wasn't accurate for users, added a users specific impl of that.

Type of Change

Please select the relevant option:

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Release
  • Other (please describe)

Related Issue

If there is an existing issue related to this pull request, please reference it here.

closes #51

Checklist

Please ensure that your pull request meets the following requirements:

  • The pull request is limited to one type (docs, feature, bug fix, etc.)
  • The pull request is as small as possible. Consider opening multiple pull requests instead of one large one.
  • The feature or bug fix has been discussed and documented in an issue beforehand.

Additional Notes

Any additional information or context regarding the pull request can be provided here.

Thank you for creating this pull request

@mwallschlaeger mwallschlaeger added the bug Something isn't working label Jun 13, 2024
@mwallschlaeger mwallschlaeger added this to the v0.2.0 milestone Jun 13, 2024
@mwallschlaeger mwallschlaeger self-assigned this Jun 13, 2024
@mwallschlaeger mwallschlaeger merged commit 165c699 into main Jun 17, 2024
3 checks passed
@mwallschlaeger mwallschlaeger deleted the issue_#51_Bug_creating_user_via_json_content_expects_username branch June 17, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: creating user via json_content expects username
1 participant