This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
start on thumbnail implementation (WIP) #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thumbnails got in already, so closing my WIP PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the global saveThumbnail function that gets called by GeoNode templates
It will post a JSON with image: true and the base64 encoded image as data property.
The endpoint needs some work that @milafrerichs is tackling in another PR, most notably: have JSON responses, remove static thumbnail.js script from template if react viewer
Also needed is a change to geonode-client that sets olMap on the state/store, this will also be handled separately.
Still need to do tests on this one.
Screenshot
Related Issue
closes #88