From 3894d1249c170228b1d94074d7f1d7463a457a25 Mon Sep 17 00:00:00 2001 From: Jordan Wilson Date: Tue, 3 Oct 2023 10:47:00 +1300 Subject: [PATCH] feat: remove push constraint for ghcr override Presence of ghcr override inputs is sufficient to allow login. --- .github/workflows/reusable-docker-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-docker-build.yml b/.github/workflows/reusable-docker-build.yml index f4e5806..37892bf 100644 --- a/.github/workflows/reusable-docker-build.yml +++ b/.github/workflows/reusable-docker-build.yml @@ -292,7 +292,7 @@ jobs: env: registryGhcrUsernameOverride: ${{ inputs.registryGhcrUsernameOverride }} registryGhcrPasswordOverride: ${{ secrets.GH_CI_USER_TOKEN }} - if: ${{ inputs.push == true && env.registryGhcrUsernameOverride != '' && env.registryGhcrPasswordOverride != '' }} + if: ${{ env.registryGhcrUsernameOverride != '' && env.registryGhcrPasswordOverride != '' }} run: | echo "${{ env.registryGhcrPasswordOverride }}" | crane auth login ghcr.io -u ${{ env.registryGhcrUsernameOverride }} --password-stdin - uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2