JsonSerializationException: 'Required property 'properties' not found in JSON

[tuyen-vuduc]

Hi,

Please allow Properties property to be nullable in JSON.

Newtonsoft.Json.JsonSerializationException: 'Required property 'properties' not found in JSON. Path '', line 1, position 93.'

[janusw]

Ran into the same problem today. Occurs e.g. when deserializing a very simple polygon geometry without any properties:

{
  "type":"Feature",
  "geometry": {
    "type":"Polygon",
    "coordinates": [..]
  }
}

[janusw]

Please allow Properties property to be nullable in JSON.

I think what you're asking is not to make the properties member nullable (it already is), but to allow it to be absent in JSON.

Tried to check the GeoJSON RFC on this matter, but it only says (see https://datatracker.ietf.org/doc/html/rfc7946#section-3.2):

      A Feature object has a member with the name "properties". The
      value of the properties member is an object (any JSON object or a
      JSON null value).

I'm not fully sure if this is actually meant to require the "properties" member to be always present. But from a "common sense" point of view, I see no reason why one shouldn't allow it to be absent (in case the feature does not have any relevant properties).

[tuyen-vuduc]

@janusw In such case, we default it to JSON null value? Many JSON serializer omits NULL value from the serialized JSON.

[janusw]

This is fixed via #167 by now.

@janusw In such case, we default it to JSON null value?

No, as you can see from the test case I added, the properties will be non-null, but empty:

GeoJSON.Net/src/GeoJSON.Net.Tests/Feature/FeatureTests.cs

Lines 32 to 41 in 36be431

	[Test]
	public void Can_Deserialize_Feature_Without_Props()
	{
	var json = GetExpectedJson();
	var feature = JsonConvert.DeserializeObject<Net.Feature.Feature>(json);
	Assert.IsNotNull(feature);
	Assert.IsNotNull(feature.Properties);
	Assert.IsEmpty(feature.Properties);

[janusw]

@xfischer I think this issue can and should be closed (I don't have the necessary permissions do close it).

[xfischer]

@janusw I gave you the permissions as you've undoubtly gained the maintainer status ;)

[janusw]

@janusw I gave you the permissions as you've undoubtly gained the maintainer status ;)

Awesome, thanks! 👍