Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Spaces mishandled in instrument names #9

Open
2 tasks
teald opened this issue Oct 29, 2024 · 0 comments
Open
2 tasks

[BUG] Spaces mishandled in instrument names #9

teald opened this issue Oct 29, 2024 · 0 comments
Assignees
@teald
Labels
bug 🐛 Something should be working but it isn't compatibility Compatibility issues. enhancement Performance or usage improvement

Comments

@teald
Copy link
Member

teald commented Oct 29, 2024

Summary

Space characters in instrument_name, e.g., "My Instrument", will fail with python names. This should likely just be a failure condition, since whitespace invites other issues.

  • Add test with expected exception for names with spaces
  • Raise exception before the template renders
@teald teald added bug 🐛 Something should be working but it isn't compatibility Compatibility issues. enhancement Performance or usage improvement labels Oct 29, 2024
@teald teald self-assigned this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teald teald

Labels
bug 🐛 Something should be working but it isn't compatibility Compatibility issues. enhancement Performance or usage improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teald