Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceReference chooser only supports Maven based plugins #33

Open
greenwoodma opened this issue May 8, 2018 · 2 comments
Open

ResourceReference chooser only supports Maven based plugins #33

greenwoodma opened this issue May 8, 2018 · 2 comments

Comments

@greenwoodma
Copy link
Contributor

Currently (and I can understand why) the new ResourceReference chooser only supports viewing resources inside plugins which are instances of Plugin.Maven. While I think that currently covers all cases, long term we should probably change this as there is nothing stopping over types of plugins offering resources. I guess we should show any plugin that returns true for hasResources although we might need to add a new method that can enumerate the resources without copying them to Plugin to support this.

@ianroberts
Copy link
Member

we might need to add a new method that can enumerate the resources without copying them to Plugin to support this.

I added such a method to Plugin.Maven specifically but it could be good to generalise this to all Plugin types.

@greenwoodma greenwoodma changed the title ResourceReference chooser only supports Mavrn based plugins ResourceReference chooser only supports Maven based plugins May 8, 2018
@greenwoodma
Copy link
Contributor Author

Yes, I think it would be good if we did (although not urgent). I guess there are other issues though around distinguishing between plugins with the same name, where the maven specific details are also used. Not sure how general we can make it, or how much it matters given the only plugin types where this currently makes much difference is the maven based ones (although it might be nice to include directory plugins in the new tab as well even if they return a file:// as it cuts down the search space)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants