Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bugs while reimplement #16

Open
Pangjing-Wu opened this issue Apr 17, 2024 · 1 comment
Open

Some bugs while reimplement #16

Pangjing-Wu opened this issue Apr 17, 2024 · 1 comment

Comments

@Pangjing-Wu
Copy link

Hi, I found some bug while reimplement ToG:

  • ./ToG/utils.py line 155: there is a typo of missing underline between “pre” and “head”
  • ./ToG/README.md lines 12 and 23: duplicated argument name, I think the duplicated one should be temperature_reasoning.
  • ./ToG/prompt_list.py lines 14 and 20: typo, it should be Entities instead of Entites. Does it affect LLM’s performance?
  • ./ToG/utils.py lines 105-110: why the code called llama server when ”llama" not in engine.lower()? I think it should call GPT 3.5-turbo in this situation.
@GasolSun36
Copy link
Owner

GasolSun36 commented Apr 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants