Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding Updates: Step 4 #739

Closed
sydney-devine opened this issue Nov 13, 2023 · 6 comments
Closed

Branding Updates: Step 4 #739

sydney-devine opened this issue Nov 13, 2023 · 6 comments
Assignees
Labels

Comments

@sydney-devine
Copy link
Collaborator

Private Zenhub Image

@bespinosa01
Copy link
Collaborator

image

@mexi-cano
Copy link
Collaborator

mexi-cano commented Dec 7, 2023

@sydney-devine @CalebPena It appears the changes request in this ticket are implemented already in the current state of Mariana's #734 Typography Updates branch. The bottom paragraph text is incorrect but may have already been addressed in Caleb's PR #794. Am I missing anything or can we close this ticket?

Current state:
Screenshot 2023-12-07 at 1 57 52 PM

Comp:
Screenshot 2023-12-07 at 1 58 19 PM

@CalebPena
Copy link
Collaborator

I did not change the bottom paragraph in my ticket, I just fixed the header. Could you update the bottom paragraph in Assets/questions.tsx. You just need to update the question description.

@mexi-cano mexi-cano linked a pull request Dec 7, 2023 that will close this issue
@sydney-devine
Copy link
Collaborator Author

I did not change the bottom paragraph in my ticket, I just fixed the header. Could you update the bottom paragraph in Assets/questions.tsx. You just need to update the question description.

@CalebPena @mexi-cano the second screenshot is the old language. We recently updated the copy on this. "This is usually family members whom you live with and share important resources with like food and bills." is the correct copy

@mexi-cano
Copy link
Collaborator

I did not change the bottom paragraph in my ticket, I just fixed the header. Could you update the bottom paragraph in Assets/questions.tsx. You just need to update the question description.

@CalebPena @mexi-cano the second screenshot is the old language. We recently updated the copy on this. "This is usually family members whom you live with and share important resources with like food and bills." is the correct copy

Updated the copy.

image

@sydney-devine
Copy link
Collaborator Author

I did not change the bottom paragraph in my ticket, I just fixed the header. Could you update the bottom paragraph in Assets/questions.tsx. You just need to update the question description.

@CalebPena @mexi-cano the second screenshot is the old language. We recently updated the copy on this. "This is usually family members whom you live with and share important resources with like food and bills." is the correct copy

Updated the copy.

image

Looks great - TY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants