Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-Cycle 9 Roman module development #1003

Open
2 of 7 tasks
rmandelb opened this issue Jan 21, 2019 · 2 comments
Open
2 of 7 tasks

post-Cycle 9 Roman module development #1003

rmandelb opened this issue Jan 21, 2019 · 2 comments
Labels
feature request Request for a new feature in GalSim roman Relevant to Roman Space Telescope specifically, especially including the galsim.roman module.

Comments

@rmandelb
Copy link
Member

rmandelb commented Jan 21, 2019

Now that the galsim.roman module is up to date with Cycle 7, there are some additional tasks that could be done:

  • Make Roman module components accessible in config
  • Include dither sequences
  • Individual pixel effects: ability to put in a flat field including effects down to the sub-pixel level. Cross-hatching pattern could then be simulated.
  • Defects like cosmic rays
  • correlated read noise: should store a correlation function in Roman module and use it to generate the read noise
  • brighter-fatter: empirically-based Antilogus-type implementation (CDModel) using coefficients measured by Chris
  • understanding WCS offsets from Chris's code

Other potential improvements to that module can be collected here.

@rmandelb rmandelb added feature request Request for a new feature in GalSim roman Relevant to Roman Space Telescope specifically, especially including the galsim.roman module. labels Jan 21, 2019
@rmjarvis
Copy link
Member

I noticed when writing text for Troxel's paper that the IPC coefficients here don't match what we are using.

I couldn't actually find the reference for our coefficients, but at least we should probably update our IPC numbers to match this one:

[0.21, 1.66, 0.22]
[1.88, 91.59, 1.87]
[0.21, 1.62, 0.20]

(unnormalized obviously)

Also, it doesn't make much sense to me that this array would not be 180 degree rotationally symmetric. Shouldn't the average correlation between a pixel and the one above it be the same as with the one below it? Likewise upper-left and lower-right, etc. I would have thought there should only be 5 independent numbers here. Am I wrong about this?

@rmjarvis
Copy link
Member

Still more things to do here, but I turned the above into a task list and checked off a couple items.
In particular, I think the WCS is pretty solid here, so I don't think whatever that was referring to is still pending. And the Roman stuff is pretty much all config-usable now, so that's been done for a while. (Since #1121)
Also, cross-referencing PR with Cycle 9 changes: #1251

@rmjarvis rmjarvis changed the title post-Cycle 7 WFIRST module development post-Cycle 9 Roman module development Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature in GalSim roman Relevant to Roman Space Telescope specifically, especially including the galsim.roman module.
Projects
None yet
Development

No branches or pull requests

2 participants