Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kindergarten form component #112

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Kindergarten form component #112

wants to merge 29 commits into from

Conversation

Alaalser
Copy link
Collaborator

Relates #55

@Alaalser Alaalser added Frontend In Progress I'm currently working on it labels Feb 16, 2021
@Alaalser Alaalser self-assigned this Feb 16, 2021
@Alaalser Alaalser linked an issue Feb 16, 2021 that may be closed by this pull request
KindergartenForm Component #55
Open
3 tasks
@Alaalser Alaalser changed the title kindergarten form component indergarten form component Feb 16, 2021
@Alaalser Alaalser changed the title indergarten form component Kindergarten form component Feb 16, 2021
@Alaalser Alaalser added Awaiting Review PR is ready for review and removed In Progress I'm currently working on it labels Feb 17, 2021
fadeomar
fadeomar reviewed Feb 22, 2021
View reviewed changes
client/src/Components/CommentContainer/index.js
itemLayout="horizontal"
dataSource={commentsToShow}
renderItem={(item) => (
<List.Item>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<List.Item>
<List.Item key="should be unique string">

source: https://ant.design/components/list/
to get more understanding about the key in React have a look here: https://reactjs.org/docs/lists-and-keys.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeomar fadeomar fadeomar left review comments

At least 4 approving reviews are required to merge this pull request.

Assignees

@Alaalser Alaalser

Labels
Awaiting Review PR is ready for review Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KindergartenForm Component
3 participants
@Alaalser @fadeomar @Osama-you