Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6,7차 세미나 기본 과제 #8

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

6,7차 세미나 기본 과제 #8

wants to merge 3 commits into from

Conversation

2zerozu
Copy link
Collaborator

@2zerozu 2zerozu commented May 31, 2023 •
edited
Loading

✒️ 관련 이슈번호

🔑 Key Changes

  1. 6주차 : JWT 관련 실습 코드
  2. 7주차 : S3 관련 실습 코드

📢 To Reviewers

  • 브랜치를 같이 써버렸네요 죄송합니다..! 그래서 6주차 코드는 거의 주석처리 되어있어요!!

@2zerozu 2zerozu added pull request🚨 피알날림 기본과제🐥 기본과제 빵주🐼 빵주가 함 labels May 31, 2023
@2zerozu 2zerozu requested a review from a team May 31, 2023 13:30
@2zerozu 2zerozu self-assigned this May 31, 2023
@2zerozu 2zerozu changed the title #3 [feat] 6,7차 세미나 기본 과제 6,7차 세미나 기본 과제 Jun 3, 2023
hayounSong
hayounSong approved these changes Jun 5, 2023
View reviewed changes
Copy link

@hayounSong hayounSong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋있어요

FourthSeminar/src/main/java/sopt/org/fourthSeminar/external/client/aws/S3Service.java

public List<String> uploadImages(List<MultipartFile> multipartFileList, String folder) {
List<String> imageList = new ArrayList<>();
multipartFileList.forEach(multipartFile ->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자바 활용도가 높으시네요!

FourthSeminar/src/main/java/sopt/org/fourthSeminar/service/UserService.java
@Transactional
public Long login(UserLoginRequestDto request) {
User user = userRepository.findByEmail(request.getEmail())
.orElseThrow(() -> new NotFoundException(Error.NOT_FOUND_USER_EXCEPTION, Error.NOT_FOUND_USER_EXCEPTION.getMessage()));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예외처리 너무 좋네요

...ar/src/main/java/sopt/org/fourthSeminar/controller/dto/request/BoardImageListRequestDto.java
import java.util.List;

@Getter
@Setter // ?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DTO에 Setter 사용이 필요한게 아니라면 없애도 좋을 것 같아요!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayounSong hayounSong hayounSong approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@2zerozu 2zerozu

Labels
pull request🚨 피알날림 기본과제🐥 기본과제 빵주🐼 빵주가 함
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6,7주차 세미나 기본 과제
2 participants
@2zerozu @hayounSong