Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate past events #11

Open
ericbhatti opened this issue Oct 26, 2017 · 5 comments
Open

Populate past events #11

ericbhatti opened this issue Oct 26, 2017 · 5 comments

Comments

@ericbhatti
Copy link

Please fetch past events details from here.

If an event's start date is in past we will show a photos button instead of registration link. Also for the events card, if the schedule array is empty, let's not show that link at all.

@TalhaKhatri
Copy link

@ericbhatti The events have been successfully populated. Please review.
@mashhoodr

@mashhoodr
Copy link
Member

mashhoodr commented Nov 30, 2017

@TalhaKhatri wheres the PR? or is this just a firebase change?

@TalhaKhatri
Copy link

TalhaKhatri commented Nov 30, 2017

@mashhoodr Yes, this was just a firebase change. Just wanted feedback if the change had any mistakes or anything. Or if something needs to be changed.

@nawazishali
Copy link

nawazishali commented Dec 7, 2017

@TalhaKhatri Run the app and you will see that event images are not the same size which in turn effects the height of event cards and makes them inconsistent. It's just a simple style fix you will need to do in order to make it look good. Ask here if you need any help with it. And there are other changes mentioned by @ericbhatti which we need to implement as well.

@TalhaKhatri
Copy link

@nawazishali Sure! Let me look into it. I'll let you know if I need any assistance, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants