-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate past events #11
Comments
@ericbhatti The events have been successfully populated. Please review. |
@TalhaKhatri wheres the PR? or is this just a firebase change? |
@mashhoodr Yes, this was just a firebase change. Just wanted feedback if the change had any mistakes or anything. Or if something needs to be changed. |
@TalhaKhatri Run the app and you will see that event images are not the same size which in turn effects the height of event cards and makes them inconsistent. It's just a simple style fix you will need to do in order to make it look good. Ask here if you need any help with it. And there are other changes mentioned by @ericbhatti which we need to implement as well. |
@nawazishali Sure! Let me look into it. I'll let you know if I need any assistance, thank you. |
Please fetch past events details from here.
If an event's start date is in past we will show a photos button instead of registration link. Also for the events card, if the schedule array is empty, let's not show that link at all.
The text was updated successfully, but these errors were encountered: