You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should we narrow the range of gradient values used for our test set? The current 1-sigma range values for temp, sigma, voff, and logN, respectively, are as the following:
My biggest concern right now is the voff range. Without some sort of beam smoothing between the pixels, individual spectra in the cube can be 'velocity-incoherent' from one another if the voff gradient is larger enough. An instance of this issue can be seen in the example NH3 (1,1) line below, where the mean spectrum of the cube is shown in grey and the central spectrum is shown in red:
The text was updated successfully, but these errors were encountered:
Well that is bad! I think we should change the line you highlighted to:
scale = np.array([[0.2, 0.1, 0.1, 0.01]])
I ran some tests with this set to 0.1 km/s and I'm not seeing these multi-peaks like we do when its at 0.2 or higher.
Okay, I've implemented your suggestion in the mcyc-pgradients branch. We can merger the branch later when we have a consensus on what these values should be for our test.
I've just submitted a pull request for this (see #15). @low-sky, @jpinedaf, @jakeown, and @rfriesen, feel free to make any further suggestions before the merge.
Should we narrow the range of gradient values used for our test set? The current 1-sigma range values for
temp
,sigma
,voff
, andlogN
, respectively, are as the following:LineFitting/nh3_testcubes.py
Line 78 in 17bd16a
My biggest concern right now is the
voff
range. Without some sort of beam smoothing between the pixels, individual spectra in the cube can be 'velocity-incoherent' from one another if thevoff
gradient is larger enough. An instance of this issue can be seen in the example NH3 (1,1) line below, where the mean spectrum of the cube is shown in grey and the central spectrum is shown in red:The text was updated successfully, but these errors were encountered: