Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

must this be called "main settings"? #17

Open
rubo77 opened this issue Feb 16, 2018 · 2 comments
Open

must this be called "main settings"? #17

rubo77 opened this issue Feb 16, 2018 · 2 comments
Labels

Comments

@rubo77
Copy link

rubo77 commented Feb 16, 2018

https://github.com/Freifunk-Nord/gluon-ssid-changer/blob/lede/gluon-ssid-changer/files/etc/config/ssid-changer#L1

not sure, if this should be

 config main 'settings'

instead?

@rubo77
Copy link
Author

rubo77 commented Feb 16, 2018

maybe here too? https://github.com/Freifunk-Nord/gluon-ssid-changer/blob/lede/gluon-ssid-changer/luasrc/lib/gluon/web/model/admin/ssid-changer.lua#L21

should this be

uci:section('ssid-changer', 'main', 'settings', {

???

@rubo77
Copy link
Author

rubo77 commented Feb 16, 2018

This should fix it: 772e9f0#diff-f74fa26a10b8d01f84115ef4865bb487R10

We call it "settings settings" now in the config file as well as in the upgrade file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant