Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packaging] DMG is missing applications symlink and background #242

Open
2 tasks done
cbenhagen opened this issue Jun 6, 2024 · 4 comments
Open
2 tasks done

[Packaging] DMG is missing applications symlink and background #242

cbenhagen opened this issue Jun 6, 2024 · 4 comments

Comments

@cbenhagen
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

The current DMG for macOS is missing a symlink to the /Applications folder. Adding a nice background would also improve the first impression.

This is what it currently looks like:
Screenshot 2024-06-06 at 08 16 29

This is how it could look like:

Screenshot 2024-06-06 at 08 10 05 Screenshot 2024-06-06 at 08 10 08

Full version info

OS: macOS 14.5
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37645 (Git)
Build type: Release
Branch: main
Hash: fc714933a7e2423d5fa4db640af549814061c42e
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: C/Default (C)
Installed mods: 
  * OpenDark 2024.3.13
  * Assembly4.backup1711882906.675722 0.50.1 (Disabled)
  * lattice2 1.0.0
  * fasteners.backup1711882906.7502148 0.4.56 (Disabled)
  * sheetmetal.backup1711882906.820294 0.2.63 (Disabled)

Subproject(s) affected?

None

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz maxwxyz transferred this issue from FreeCAD/FreeCAD Jun 6, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Jun 6, 2024

@adrianinsaval what do you need to implement this?

@cbenhagen
Copy link
Contributor Author

I evaluated different methods to create a nice DMG. The python package dmgbuild seems to be the most appropriate to use here.

  1. Install with pip install "dmgbuild[badge_icons]"
  2. Create a settings.py with this content:
background = "builtin-arrow"
files = ["/Applications/FreeCAD.app"]
symlinks = {"Applications": "/Applications"}
badge_icon = "/Applications/FreeCAD.app/Contents/Resources/freecad.icns"
window_rect = ((100, 100), (670, 250))
icon_locations = {"FreeCAD.app": (100, 100), "Applications": (530, 100)}
  1. dmgbuild -s settings.py "FreeCAD" FreeCAD.dmg; open FreeCAD.dmg
Screenshot 2024-06-09 at 12 17 56

This example uses the built-in default arrow of the tool but I am sure someone will come up with a nicer background.

It looks like there are currently different scripts being used to create the stable release and the weekly builds. Are there plans to unify them?

@cbenhagen
Copy link
Contributor Author

Background discussion topic on Discord:
https://discord.com/channels/870877411049357352/1249312427624108032

@adrianinsaval
Copy link
Member

do we have an image for this yet? since we are already using dmgbuild now adding the image should be trivial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants