Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate conditions in MARK rules #400

Open
shahrzadav opened this issue Dec 29, 2021 · 0 comments
Open

Duplicate conditions in MARK rules #400

shahrzadav opened this issue Dec 29, 2021 · 0 comments

Comments

@shahrzadav
Copy link

In the following rule from the Bouncy Castle ruleset, the _is(m.key, kg.key) is mentioned as precondition and condition both. Based on MARK, the condition statement will be examined if a precondition is met. Therefore, it does not make sense to have this condition in both places. Am I missing something here, or is this just a mistake?

rule ID_5_3_02_CMAC_Keygen {
    using
        Mac as m,
        KeyGenerator as kg
    when
        m.algorithm in ["AESCMAC"]
        && _is(m.key, kg.key)
    ensure
        // find a keygenerator of sufficient size
        _is(m.key, kg.key)
        && kg.keysize >= 128
    onfail
        InsufficientCMACKeyLength
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant