From efa8082f5da2c30f2d4797702daf4dbbcca23873 Mon Sep 17 00:00:00 2001
From: FrancoisCarouge <francois.carouge@gmail.com>
Date: Sun, 12 Jan 2025 21:31:42 -0800
Subject: [PATCH] [linalg] avoid auto and deduce type

---
 include/fcarouge/utility.hpp | 8 ++++----
 test/kalman_f_5x4x3.cpp      | 1 -
 test/linalg_zero.cpp         | 2 +-
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/include/fcarouge/utility.hpp b/include/fcarouge/utility.hpp
index 256d8e209..9ac93a4e9 100644
--- a/include/fcarouge/utility.hpp
+++ b/include/fcarouge/utility.hpp
@@ -253,11 +253,11 @@ inline constexpr Arithmetic identity<Arithmetic>{1};
 
 template <typename Type>
   requires requires { Type::Identity(); }
-inline auto identity<Type>{Type::Identity()};
+inline Type identity<Type>{Type::Identity()};
 
 template <typename Type>
   requires requires { Type::identity(); }
-inline auto identity<Type>{Type::identity()};
+inline Type identity<Type>{Type::identity()};
 
 //! @brief The zero matrix.
 //!
@@ -272,11 +272,11 @@ inline constexpr Arithmetic zero<Arithmetic>{0};
 
 template <typename Type>
   requires requires { Type::Zero(); }
-inline auto zero<Type>{Type::Zero()};
+inline Type zero<Type>{Type::Zero()};
 
 template <typename Type>
   requires requires { Type::zero(); }
-inline auto zero<Type>{Type::zero()};
+inline Type zero<Type>{Type::zero()};
 
 //! @}
 
diff --git a/test/kalman_f_5x4x3.cpp b/test/kalman_f_5x4x3.cpp
index a6131b258..d6e807d83 100644
--- a/test/kalman_f_5x4x3.cpp
+++ b/test/kalman_f_5x4x3.cpp
@@ -51,7 +51,6 @@ template <auto Row, auto Column> using matrix = matrix<double, Row, Column>;
 [[maybe_unused]] auto test{[] {
   const auto i5x5{identity<matrix<5, 5>>};
   const auto z5x5{zero<matrix<5, 5>>};
-  const vector<3> z3{zero<vector<3>>};
   kalman filter{state{vector<5>{0., 0., 0., 0., 0.}}, output<vector<4>>,
                 input<vector<3>>, update_types<double, float, int>,
                 prediction_types<int, float, double>};
diff --git a/test/linalg_zero.cpp b/test/linalg_zero.cpp
index a59509a50..affe7550d 100644
--- a/test/linalg_zero.cpp
+++ b/test/linalg_zero.cpp
@@ -44,7 +44,7 @@ namespace fcarouge::test {
 namespace {
 //! @test Verifies the zero matrices values are null.
 [[maybe_unused]] auto test{[] {
-  auto z{zero<matrix<double, 3, 3>>};
+  matrix z{zero<matrix<double, 3, 3>>};
 
   assert(z(0, 0) == 0.0);
   assert(z(0, 1) == 0.0);