Add finite depth functionality to SurfaceQG
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added multiple dispatch to replace the if-else logic. CI failing for documentation, not sure why. |
navidcy
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Suggestion:
At the moment there is no variable for stream function. If we introduce ψh in Vars then we can call streamfunctionfromb! within calcN_advection!. This way, by having multiple dispatch on streamfunctionfromb! we'll sort out the finite/infinite depth cases without having to almost-duplicate calcN_advection!. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue 374