Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Foundry v12 Support #18

Open
mcabel opened this issue Jul 29, 2024 · 6 comments
Open

[Enhancement] Foundry v12 Support #18

mcabel opened this issue Jul 29, 2024 · 6 comments

Comments

@mcabel
Copy link

mcabel commented Jul 29, 2024

Can you please add support for foundry version 12 with dnd 3.3.1 + ?

@Forien
Copy link
Member

Forien commented Jul 29, 2024

Is there any specific issue you are encountering? If so, a bug report would be appreciated.

@mcabel
Copy link
Author

mcabel commented Jul 30, 2024

I'll keep testing and report a bug if I find anything more specific. Thanks for your attention.

@BlackBadger777
Copy link

BlackBadger777 commented Aug 5, 2024

I just tried using ItemMacro with v12 and DnD5e 3.3.1. Unfortunately, it doesn't seem to be functional. A macro I put on an item is supposed to execute and present a dialog instead of outputting the item to chat, but the macro doesn't fire and the item is sent to chat. There is no error message in the console. Executing the macro manually from itemmacro's sheet will trigger the macro in its intended form.

I can file a separate bug report, too, if needed.

@Forien
Copy link
Member

Forien commented Aug 5, 2024

I just tried using ItemMacro with v12 and DnD5e 3.3.1. Unfortunately, it doesn't seem to be functional. A macro I put on an item is supposed to execute and present a dialog instead of outputting the item to chat, but the macro doesn't fire and the item is sent to chat. There is no error message in the console. Executing the macro manually from itemmacro's sheet will trigger the macro in its intended form.

I can file a separate bug report, too, if needed.

Have you enabled the Override default macro execution in the module's settings?

@BlackBadger777
Copy link

Ah, shoot. I thought I had set up my module settings exactly as in my old world, but this one slipped my notice. I apologize! Now it seems to work, although it throws an error message when used with Tidy5e sheets. But that is a separate issue, which I will take to that module's author. Thank you so much for the quick reply!

@fegarza7
Copy link

I second this, no issues encountered it just looks yellow on my modules.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants