Resolves #135: DocLayer is not able to handle sparse arrays correctly. #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 15, 2019 13:13
…it really should do a deep copy.
- {} should NOT match anything other than an empty dictionary in some cases
- indexes should be checked after all update operators
…string, where it should be '[]'
apkar
approved these changes
Apr 23, 2019
| # if (r < 0.1) and generator_options.test_nulls: | ||
| # val = None | ||
| # val = None |
There was a problem hiding this comment.
With this patch, is it time to re-enable None value tests?
There was a problem hiding this comment.
Will do in the PR that adds deletion tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the null imputing logic used when doing path expansion is not handling the sparse array at all. This PR mainly resolves that problem by adding a third case when it impute a null value. This PR also fixed several bugs in MongoModel.
Regarding to the sparse array: right now in
insertElementRecursive(), DocLayer does NOT try to store arrays with null values as sparse arrays, which is kind of against what it attempts to do later when doing update. Filed #164 tracking that.