Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass around IndexInfo instead of bson::BSONObj #136

Open
apkar opened this issue Apr 4, 2019 · 1 comment
Open

Pass around IndexInfo instead of bson::BSONObj #136

apkar opened this issue Apr 4, 2019 · 1 comment
Labels
cleanup Code or design cleanup
Milestone

Comments

@apkar
Copy link
Contributor

apkar commented Apr 4, 2019

In the code, we pass around index information a lot, especially in the metadata handling code. The code would look much cleaner if we are passing around IndexInfo instead of bson::BSONObj. That would avoid serialization/deserialization lots of different places uses CPP typing instead of BSON type checks.

@apkar apkar added the cleanup Code or design cleanup label Apr 4, 2019
@dongxinEric
Copy link
Contributor

We probably want to expand this to profile first and then audit the serialization and deserialization code in general in doc layer.

@apkar apkar added this to the 1.8.0 milestone Apr 8, 2019
@apkar apkar modified the milestones: 1.8.0, 2.0.0 Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code or design cleanup
Projects
None yet
Development

No branches or pull requests

2 participants