Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual feedback to indicate recording being stopped and processed #49

Closed
6 of 7 tasks
Cwpute opened this issue Apr 10, 2024 · 5 comments
Closed
6 of 7 tasks

Visual feedback to indicate recording being stopped and processed #49

Cwpute opened this issue Apr 10, 2024 · 5 comments
Labels
invalid This does not seem right

Comments

@Cwpute
Copy link

Cwpute commented Apr 10, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

When a recording is stopped, reset the waveform preview and record time, and when a recording is being processed, show a toast message saying what's happening.
Alternatively you could have a "loading" icon appear somewhere (instead of the play button?) if you can't record anything while something else is processed.

Why do you want this feature?

When you stop the recording, nothing tells the user that their recording has been saved or either processed, quite the contrary: the screen looks just like when you pause a recording. It makes it-impossible to know without practice if the app acted as expected or not.
My own use case was sending an audio message by SMS (via Fossify SMS): when i stopped the recording, it would just hang for about 5 seconds, then automatically quit and get back to Fossify SMS with my recording ready. If i didn't know any better, i would have thought the app behaved badly, didn't save the recording or that i made a mistake, and may have quitted the app myself or try to record again.

Additional information

No response

@Cwpute Cwpute added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Apr 10, 2024
@Aga-C
Copy link
Member

Aga-C commented Apr 10, 2024

show a toast message saying what's happening
(...)
When you stop the recording, nothing tells the user that their recording has been saved

But there is a toast message saying that recording has been saved. It sounds more like your phone became unresponsive for a moment, and that's why it haven't shown a toast from the app. It seems to be related to this performance issue: #22.

@Aga-C Aga-C added invalid This does not seem right and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Apr 10, 2024
@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
@Cwpute
Copy link
Author

Cwpute commented Apr 11, 2024

There indeed is a toast message, somehow it eluded me, sorry.
But the fact i didn't register it after having used Fossify's audio recorder since it was published on the Fdroid store shows that it is easily obscured by other things happening on the screen. It shows this toast message is not enough.

The second part of my suggestion, acting on the waveform visualizer, would at least reset the main aspect of the record screen to how it is before any recording starts.

Regarding my specific use case i'll try to record a video of what happens to more clearly show you the problem.

@Cwpute
Copy link
Author

Cwpute commented Apr 11, 2024

hang4sec.processed.mp4

As you can see here the audio recorder hangs for almost 4 seconds during which nothing happens, nothing is shown on the screen. Unknowing users might think the recording failed and try to switch apps, go back etc... and lose themselves while the recorder is actually doing its job.
Again, removing the waveform and showing a animated loading icon somewhere would at least reassure us the app is working and not stuck or something.

@Aga-C
Copy link
Member

Aga-C commented Apr 11, 2024

We already have a feature request raised to have progress dialogs in all apps, so this could help in your case. See: FossifyOrg/General-Discussion#120.

@Cwpute
Copy link
Author

Cwpute commented Jun 10, 2024

This would help indeed.
Meanwhile, could you reopen this issue so the state of this issue is correctly represented ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This does not seem right
Projects
None yet
Development

No branches or pull requests

2 participants