Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp3 should be the automatic file extension type #35

Closed
6 of 7 tasks
RustoMCSpit opened this issue Feb 26, 2024 · 8 comments · Fixed by #36
Closed
6 of 7 tasks

mp3 should be the automatic file extension type #35

RustoMCSpit opened this issue Feb 26, 2024 · 8 comments · Fixed by #36
Labels
enhancement New feature or request

Comments

@RustoMCSpit
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

make .mp3 the default audio format. not to be rude but closing this last time was pedantic.

Why do you want this feature?

m4a is not foss and it should say that in the 'select file type menu'

Describe alternatives you've considered:
on first open of the app ask the user to input desired file extension and clarify that m4a isnt foss

Additional information

just make mp3 the default until flac is integrated / opus is fixed

@RustoMCSpit RustoMCSpit added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Feb 26, 2024
@Aga-C Aga-C added enhancement New feature or request and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Feb 26, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 26, 2024

As Naveen said in your previous request, we'll change default to MP3. However, we probably won't change it to FLAC or Opus. We don't want to enforce users into saving recordings that can take much space (FLAC). We don't plan on setting Opus as default until it will work on every Android (currently it's for 10+).

Aga-C added a commit to Aga-C/Voice-Recorder that referenced this issue Feb 26, 2024
@osering
Copy link

osering commented Feb 28, 2024

As Naveen said in your previous request, we'll change default to MP3. However, we probably won't change it to FLAC or Opus. We don't want to enforce users into saving recordings that can take much space (FLAC). We don't plan on setting Opus as default until it will work on every Android (currently it's for 10+).

It is misleading to say, that opus does not work with Android 9-. Opus codec is recognized starting with Android 5 (A5 - .webm, .mka, .mkv extensions, A7-A9 - .ogg & .oga extensions, A10-A14 - .opus and all all others), opus extension recognized starting with mainstream Android 10 (Lineage 16 (Android 9)).
https://en.m.wikipedia.org/wiki/Opus_(audio_format)#Operating_system_support
So, just according to Android version extension shall be changed, leaving file the same.
Therefore there could be 2 solutions:

  1. app according to Android version offers right extension to opus files, or
  2. let user to choose extension manually in the app.

Moreover there is question - how recognition/compliance is defined/measured - by capabilities of operating system itself, by (outdated, 5 years+ not-updated) file manager capabilities (of knowing what to do wilt .opus file) or by outdated music player capabilities (modern, up-to-date players shall open/play .opus even if installed on older operating system. So most probably old (neglected) applications and not operating system itself is to blame. For example, try using fresh FX File Explorer and Vanilla Music or Poweramp...

Even by mere count, we can see, that opus partial compliance is alleged in Android 5, 6-9, full 10-14. So majority to date is compliant fully.

Most probably opus codec will never ever play on Android 4 and more ancient as nobody most probably will backport it - so as can be understood - .opus never will be default in this app?

@Aga-C
Copy link
Member

Aga-C commented Feb 28, 2024

@osering I said we don't plan on setting Opus as default until it will work on every Android, because Fossify Voice Recorder supports it from Android 10+.

@osering
Copy link

osering commented Mar 26, 2024

So never :D
P.S. You were now specific enough on at what level compliance is measured - OS codec, some file manager, stock player availability...
https://developer.android.com/media/platform/supported-formats

@OkyDooky
Copy link

I think what he means is encoding rather than decoding. Decoding support is, as you've pointed out, already supported on virtually every device. It's encoding that's the issue.
Aga-C goes into more detail when he responded to me asking about Opus availability: SimpleMobileTools/Simple-Voice-Recorder#178

So, one option is to bundle Opus recording support directly in the app, instead of Android's built-in system library. But, that's work that someone will have to do.

@naveensingh
Copy link
Member

Aga-C goes into more detail when he responded

she*

I think Android 10+ is not that bad, it's available on the cheapest phones I could find for testing. Our efforts are better focused on improving and implementing things for more recent versions.

@OkyDooky
Copy link

she*

There are no girls on the internet. I thought everyone knew that. ;P

I think Android 10+ is not that bad, it's available on the cheapest phones I could find for testing. Our efforts are better focused on improving and implementing things for more recent versions.

So, what does that mean for this issue specifically? The thread made it seem like Opus will become default if/when Android 10 and above is the norm, which you are saying is now.
Not disagreeing with anything, just unsure what statements are applied to what.

naveensingh added a commit that referenced this issue Sep 20, 2024
Changed default file type to MP3 (#35)
@naveensingh
Copy link
Member

Opus will become default if/when Android 10 and above is the norm, which you are saying is now.

We'll switch to Opus when the minimum Android version supported by Fossify apps is Android 10. Right now the minimum Android version is either 6 or 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants