Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect toast behaviour when disabling alarms #26

Open
7 tasks done
pudup opened this issue Feb 28, 2024 · 3 comments
Open
7 tasks done

Incorrect toast behaviour when disabling alarms #26

pudup opened this issue Feb 28, 2024 · 3 comments
Labels
bug Something is not working

Comments

@pudup
Copy link
Contributor

pudup commented Feb 28, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.0

Affected Android/Custom ROM version

Android 12+

Affected device model

Pixel 8

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

Mirror of
SimpleMobileTools/Simple-Clock#550

Have a non-repeating alarm that is due today
Turn it off
A toast appears when it shouldn't
Turning it back on triggers 2 toasts

Expected behavior

No toast when disabling an alarm

Actual behavior

A toast displaying the time remaining is triggered when the alarm is disabled

Screenshots/Screen recordings

No response

Additional information

No response

@pudup pudup added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Feb 28, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 28, 2024

Can you provide more detailed steps? I try to do as you wrote, but I can't reproduce the issue.

Also, please don't link to the Simple Clock repository for more details, as these issues can disappear any time.

@Aga-C Aga-C added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Feb 28, 2024
@pudup
Copy link
Contributor Author

pudup commented Feb 29, 2024

I wrote incorrectly. It only occurs with alarms that are NOT recurring. Single use alarms have this issue.

Steps

  1. Turn on an alarm that triggers today.
  2. Turn it off and a toast fires

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Feb 29, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 29, 2024

Thanks! Now I can reproduce this bug.

@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

2 participants