Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tagging events hosted on external (CalDAV) calendars. #162

Open
6 of 7 tasks
RokeJulianLockhart opened this issue Feb 23, 2024 · 6 comments
Open
6 of 7 tasks
Labels
feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up

Comments

@RokeJulianLockhart
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

A one-to-many correspondence, possible to combine and exclude when filtering.

Why do you want this feature?

To organize them in a manner which embeds into the iCS file / calendar event.

Additional information

FossifyOrg/General-Discussion#127 (comment)

@RokeJulianLockhart RokeJulianLockhart added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Feb 23, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 23, 2024

Isn't event types enough? You can already filter by them.

@Aga-C Aga-C added question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Feb 23, 2024
@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Feb 23, 2024
@Aga-C Aga-C removed the question Further information is requested label Feb 23, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 23, 2024

Event types are supported only for local calendar. It's currently not supported for CalDAV synchronized calendars, because the app treats synchronized calendar as an event type itself. We'd need to add distinction between calendars and event types, what may even be a bit related to #92.

@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Feb 23, 2024

#162 (comment)

@Aga-C, glad for the context, although I fail to see how that correlates it with #162 (comment) specifically. Regardless, should this issue be renamed to reflect the specific absence of the feature on all except local calendars consequently? After all, it seems like the feature exists in that specific context, so the scope of the issue should probably be reduced. I'll do so unless you disagree.

@RokeJulianLockhart RokeJulianLockhart changed the title Support tagging. Support tagging entries hosted on external (CalDAV) calendars. Feb 23, 2024
@RokeJulianLockhart RokeJulianLockhart changed the title Support tagging entries hosted on external (CalDAV) calendars. Support tagging events hosted on external (CalDAV) calendars. Feb 23, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 23, 2024

I was thinking about that once again, and I'm just curious about the example you've sent from NextCloud. By tagging events, you mean that those events are tagged as "Everything"?

If so, this is the same as event type in Fossify Calendar. What's more, you can already change them. The only requirement is that you need to have them defined on your CalDAV provider and synchronized in the app, as we can't create new ones due to no Internet access.

@Aga-C Aga-C added question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Feb 23, 2024
@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Feb 23, 2024

#162 (comment)

@Aga-C, I believe you're referring to something else, for “Everything” is the name of the calendar itself. What I'm describing is what https://github.com/nextcloud/documentation/blob/9f188a307f92d634551cde6129d958b21b4f6fdb/user_manual/groupware/calendar.rst#add-attachments-to-events depicts (although unfortunately the documentation lacks explicit description of the feature, per nextcloud/documentation#789 (comment)):

image

However, it's obviously tags.

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Feb 23, 2024
@Aga-C Aga-C removed the question Further information is requested label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up
Projects
None yet
Development

No branches or pull requests

2 participants