Skip to content
This repository has been archived by the owner on Dec 18, 2022. It is now read-only.

No return log for android app #4

Open
jakoss opened this issue Jan 4, 2021 · 2 comments
Open

No return log for android app #4

jakoss opened this issue Jan 4, 2021 · 2 comments

Comments

@jakoss
Copy link

jakoss commented Jan 4, 2021

I'm trying to use this library on only-android (no multiplatform setup) app. I used plugin and de.jensklingenberg.cabret:cabret-log, both with 1.0.3 versions. I enabled cabret and useIR in kotlinOptions block like that:
image

Whenever i use @DebugLog annotation i only have the function entry log. The return log never arrives (i checked in custom logger with breakpoint - only entry logs arrive there)

@jakoss
Copy link
Author

jakoss commented Jan 4, 2021

I'm sorry, the issue happens only for functions that do not return result.
I can see that in transformer you are looking for "return value", but i believe that without handling functions without return this library isn't that useful (most functions i'm looking to measure are overridden UI functions without return values). I didn't look at kotlin compilers so i'm not sure if i can help here. Looking forward to learn it though, seems interesting.

I think the timer can be stopped inside irBlockBody if the visitReturn from transformReturnValue was never visited

@Foso
Copy link
Owner

Foso commented Jan 4, 2021

Thank you for reporting this, i will take a look it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants