Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Glob patterns for trace.allowMissing. #140

Open
ryan-roemer opened this issue Aug 17, 2020 · 2 comments
Open

Feature: Glob patterns for trace.allowMissing. #140

ryan-roemer opened this issue Aug 17, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@ryan-roemer
Copy link
Member

See discussion in #116 and repository at: https://github.com/dominics/issue-jp-sh/blob/main/serverless.yml#L36

Maybe limit this to only relative files to simplify the require resolution issues?

@nVitius
Copy link

nVitius commented Dec 15, 2022

Would be nice to have this feature. My use case is for TypeORM, which has a lot of optional peer dependencies.
It would be great if we could do something like this:

allowMissing:
  typeorm:
    - "*"

@ryan-roemer
Copy link
Member Author

@nVitius Thanks for chiming in. I'm actually tracking this issue in a monorepo where Jetpack is in the process of transitioning to: FormidableLabs/tracing#15

As a head's up on timing, it's definitely a little bit out -- I've got to get jetpack over to that repo and updated to serverless3.

For this specific issue, the tricky part is that a glob deals with a known starting place in a filesystem vs. the config options here are based on Node.js require/import traversal algorithim which descends the opposite direction in the file system and can match in an unpredictable manner. So, I'm also considering other solutions that aren't necessarily glob-based.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants